Skip to content

Update session also for non sampled events and change filter order #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 20, 2022
Merged

Update session also for non sampled events and change filter order #1394

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
29692eb
Update session also for non sampled events and change filter order
adinauer Apr 14, 2022
5edb634
Update client.py
adinauer Apr 14, 2022
a3bc972
Specify return type
adinauer Apr 14, 2022
1c3e4d0
Merge branch 'master' into adinauer-patch-1
sl0thentr0py Apr 20, 2022
3b5fdef
New sample function is only for errors
sl0thentr0py Apr 20, 2022
d4cb745
Learn how to commit
sl0thentr0py Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion sentry_sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,13 @@ def _should_capture(
if ignored_by_config_option:
return False

return True

def _should_sample_error(
self,
event, # type: Event
):
# type: (...) -> bool
not_in_sample_rate = (
self.options["sample_rate"] < 1.0
and random.random() >= self.options["sample_rate"]
Expand Down Expand Up @@ -349,9 +356,13 @@ def capture_event(
if session:
self._update_session_from_event(session, event)

attachments = hint.get("attachments")
is_transaction = event_opt.get("type") == "transaction"

if not is_transaction and not self._should_sample_error(event):
return None

attachments = hint.get("attachments")

# this is outside of the `if` immediately below because even if we don't
# use the value, we want to make sure we remove it before the event is
# sent
Expand Down