Skip to content

Suppress prompt spawned by subprocess when using pythonw #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Suppress prompt spawned by subprocess when using pythonw #1079

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3e0b9f
Suppress prompt spawned by subprocess when using pythonw
collinbanko Apr 9, 2021
d772e68
Merge branch 'getsentry:master' into fix/subprocess-prompt
collinbanko May 11, 2021
20d597e
Merge branch 'getsentry:master' into fix/subprocess-prompt
collinbanko Apr 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sentry_sdk/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,17 @@ def get_default_release():
if release:
return release

startupinfo = None
if sys.platform == "win32" or sys.platform == "cygwin":
startupinfo = subprocess.STARTUPINFO()
startupinfo.dwFlags |= subprocess.STARTF_USESHOWWINDOW

with open(os.path.devnull, "w+") as null:
try:
release = (
subprocess.Popen(
["git", "rev-parse", "HEAD"],
startupinfo=startupinfo,
stdout=subprocess.PIPE,
stderr=null,
stdin=null,
Expand Down