-
-
Notifications
You must be signed in to change notification settings - Fork 462
docs: Update README.md & add CONTRIBUTING.md #1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I wonder if we should really enter the rabbit hole of how to install PHP, rather than just saying that it is a prerequisite for the working environment (of course) |
|
I agree, we shouldn't provide a step-by-step installation guide for PHP plenty of info on that on the internet, but we can give some guidance on where to get it. Maybe some inspiration can be taken from the Laravel SDK where I updated the guide few months ago: |
|
I aligned the |
04de0b9 to
b4f9b94
Compare
vladanpaunovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with above sentiments from @stayallive and @ste93cry (thanks folks!).
Other than that, this looks good. Nice addition to this repo! Thanks @cleptric! 🥳
Co-authored-by: Alex Bouma <[email protected]>
Co-authored-by: Alex Bouma <[email protected]>
|
Based on #1289, I made some changes to the README.md as well. |
stayallive
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we can always keep iterating on this 😄
This is based on our Laravel SDK CONTRIBUTING.md.
Please let me know if I should add more things or if anything in here is plain wrong.
Closes #1289