fix: sdk name #57
Merged
fix: sdk name #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
reviewed
Mar 16, 2023
| Pod::Spec.new do |spec| | ||
| spec.name = 'sentry_kotlin_multiplatform' | ||
| spec.version = '0.0.1' | ||
| spec.version = '0.0.1-alpha.2' |
Contributor
There was a problem hiding this comment.
Suggested change
| spec.version = '0.0.1-alpha.2' | |
| spec.version = '0.0.1' |
Contributor
There was a problem hiding this comment.
Isn't this file that we agreed to keep it as it is? similar to Flutter.
Contributor
Author
There was a problem hiding this comment.
Yes, it auto-increments on every build and forgot to unstage it. Maybe I should add it to gitignore from now on?
Contributor
There was a problem hiding this comment.
maybe remove the part that makes it auto-increment?
Contributor
Author
There was a problem hiding this comment.
seems like pinning the version to 0.0.1 in the cocoapods gradle plugin works
marandaneto
reviewed
Mar 16, 2023
...y-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/SentryOptions.kt
Show resolved
Hide resolved
marandaneto
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the sdk name that is now applicable for hybrid sdks
Working examples: