-
-
Notifications
You must be signed in to change notification settings - Fork 19
feat: add app hang / anr #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
70230c9
add options
buenaflor 7173344
Add test
buenaflor b346f6f
add test
buenaflor 3c7c0fe
Format code
getsentry-bot 158747d
Update CHANGELOG
buenaflor b2c2a28
Update tests
buenaflor 30be8be
add api
buenaflor 9b7cd20
Fix detekt
buenaflor 56ad029
Merge branch 'main' into feat/app-hang
buenaflor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,4 +50,4 @@ Pod::Spec.new do |spec| | |
| } | ||
| ] | ||
|
|
||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
...form/src/androidUnitTest/kotlin/io/sentry/kotlin/multiplatform/PlatformOptions.android.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| package io.sentry.kotlin.multiplatform | ||
|
|
||
| import io.sentry.android.core.SentryAndroidOptions | ||
| import io.sentry.kotlin.multiplatform.extensions.toAndroidSentryOptionsCallback | ||
| import kotlin.test.assertEquals | ||
|
|
||
| actual interface PlatformOptions : CommonPlatformOptions { | ||
| val isAnrEnabled: Boolean | ||
| val anrTimeoutIntervalMillis: Long | ||
| val attachScreenshot: Boolean | ||
| val attachViewHierarchy: Boolean | ||
| } | ||
|
|
||
| class SentryAndroidOptionsWrapper(private val androidOptions: SentryAndroidOptions) : | ||
| PlatformOptions { | ||
| override val dsn: String? | ||
| get() = androidOptions.dsn | ||
|
|
||
| override val attachStackTrace: Boolean | ||
| get() = androidOptions.isAttachStacktrace | ||
|
|
||
| override val release: String? | ||
| get() = androidOptions.release | ||
|
|
||
| override val debug: Boolean | ||
| get() = androidOptions.isDebug | ||
|
|
||
| override val environment: String? | ||
| get() = androidOptions.environment | ||
|
|
||
| override val dist: String? | ||
| get() = androidOptions.dist | ||
|
|
||
| override val enableAutoSessionTracking: Boolean | ||
| get() = androidOptions.isEnableAutoSessionTracking | ||
|
|
||
| override val sessionTrackingIntervalMillis: Long | ||
| get() = androidOptions.sessionTrackingIntervalMillis | ||
|
|
||
| override val maxBreadcrumbs: Int | ||
| get() = androidOptions.maxBreadcrumbs | ||
|
|
||
| override val maxAttachmentSize: Long | ||
| get() = androidOptions.maxAttachmentSize | ||
|
|
||
| override val sampleRate: Double? | ||
| get() = androidOptions.sampleRate | ||
|
|
||
| override val tracesSampleRate: Double? | ||
| get() = androidOptions.tracesSampleRate | ||
|
|
||
| override val isAnrEnabled: Boolean | ||
| get() = androidOptions.isAnrEnabled | ||
|
|
||
| override val anrTimeoutIntervalMillis: Long | ||
| get() = androidOptions.anrTimeoutIntervalMillis | ||
|
|
||
| override val attachScreenshot: Boolean | ||
| get() = androidOptions.isAttachScreenshot | ||
|
|
||
| override val attachViewHierarchy: Boolean | ||
| get() = androidOptions.isAttachViewHierarchy | ||
|
|
||
| override fun applyFromOptions(options: SentryOptions) { | ||
| options.toAndroidSentryOptionsCallback().invoke(androidOptions) | ||
| } | ||
| } | ||
|
|
||
| actual fun createPlatformOptions(): PlatformOptions = | ||
| SentryAndroidOptionsWrapper(SentryAndroidOptions()) | ||
|
|
||
| actual fun PlatformOptions.assertPlatformSpecificOptions(options: SentryOptions) { | ||
| assertEquals(attachScreenshot, options.attachScreenshot) | ||
| assertEquals(attachViewHierarchy, options.attachViewHierarchy) | ||
| assertEquals(isAnrEnabled, options.isAnrEnabled) | ||
| assertEquals(anrTimeoutIntervalMillis, options.anrTimeoutIntervalMillis) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
...lin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/PlatformOptions.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package io.sentry.kotlin.multiplatform | ||
|
|
||
| interface CommonPlatformOptions { | ||
| val dsn: String? | ||
| val attachStackTrace: Boolean | ||
| val release: String? | ||
| val debug: Boolean | ||
| val environment: String? | ||
| val dist: String? | ||
| val enableAutoSessionTracking: Boolean | ||
| val sessionTrackingIntervalMillis: Long | ||
| val maxBreadcrumbs: Int | ||
| val maxAttachmentSize: Long | ||
| val sampleRate: Double? | ||
| val tracesSampleRate: Double? | ||
|
|
||
| fun applyFromOptions(options: SentryOptions) | ||
| } | ||
|
|
||
| expect interface PlatformOptions : CommonPlatformOptions | ||
|
|
||
| expect fun createPlatformOptions(): PlatformOptions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.