Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 19, 2024

📜 Description

Adds isCrashedLastRun

Note: codecov ci fails because I haven't added any test, not sure what the best way to test here is since mocking on KMP is not really a thing yet

💡 Motivation and Context

Closes #178

💚 How did you test it?

Manually

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

@buenaflor buenaflor requested a review from romtsn as a code owner February 19, 2024 23:54
@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 76463a5

@codecov
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a0767b5) 77.83% compared to head (76463a5) 77.46%.

Files Patch % Lines
...io/sentry/kotlin/multiplatform/SentryBridge.jvm.kt 0.00% 1 Missing ⚠️
...kotlin/io/sentry/kotlin/multiplatform/SentryKMP.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   77.83%   77.46%   -0.37%     
==========================================
  Files          27       27              
  Lines         424      426       +2     
  Branches       55       56       +1     
==========================================
  Hits          330      330              
- Misses         68       70       +2     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can omit tests and rely on the native SDKs here, otherwise would've use a lot of internal stuff to test it probably

@buenaflor buenaflor merged commit 75e574e into main Feb 22, 2024
@buenaflor buenaflor deleted the feat/is-crashed-last-run branch February 22, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isCrashedLastRun method

3 participants