ref(serverless): Use startSpanManual() instead of startTransaction()
#9970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/idleTransaction
branch
from
8bc1613 to
a9d120e
Compare
Lms24
approved these changes
Dec 22, 2023
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Nice, this really looks way cleaner!
mydea
force-pushed
the
fn/idleTransaction
branch
from
7747255 to
3a5d3f9
Compare
AbhiPrasad
approved these changes
Dec 22, 2023
anonrig
pushed a commit
that referenced
this pull request
Jan 3, 2024
…()` (#9970) Also refactor it to use `continueTrace`. Note that this already uses the "new" way of `startSpanManual` which ignores the `finish` function. --------- Co-authored-by: Lukas Stracke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor it to use
continueTrace.Note that this already uses the "new" way of
startSpanManualwhich ignores thefinishfunction.