ref(remix): Isolate Express instrumentation from server auto-instrumentation.

[onurtemizkan]

Potentially fixes: #9963

We have been using a boolean flag isRequestHandlerWrapped in the scope of instrumentServer to avoid instrumenting Remix build multiple times when an Express server adapter is manually instrumented too.

The reason behind that decision was that we could not be sure that the build object is the same, so looking for __sentry_original__ on the wrapped function was not reliable all the time.

While we still can't reproduce locally, #9963 showed that this strategy (hack) may not work all the time, so I tried to find an alternative reliable way to resolve this.

This PR introduces instrumentation for getLoadContext which is available in all Remix server adapters, and passes data to loader/action/requestHandlers, to supply information about in which context a wrapped loader / action / requestHandler is used.

We still run instrumentBuild inside Sentry.init for all Express / non-Express applications, but with this context, we can gauge the behaviour of instrumented functions, depending on which instrumentBuild they're invoked from.

So, with this PR we maintain two side-effect free flags:

• __sentry_express_wrapped__ from the instrumented getLoadContext
• manuallyInstrumented flag we pass to instrumentBuild function which can be invoked either from Sentry.init or wrapExpressCreateRequestHandler

Having those two, an instrumented loader / action / requestHandler will behave accordingly to avoid creating multiple transactions.

This approach can also be applied to injecting baggage and sentry-trace as mentioned in #9737 in a new PR, if this gets merged.

Additionally, this PR makes a slight change on the ordering of host lookup of RequestData, which I came across while testing this.

Still not sure if this fixes the exact problem mentioned in #9963, but regardless IMHO it feels like a better resolution for this problem. cc: @souredoutlook

[github-actions]

size-limit report 📦

Path	Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped)	75.92 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped)	67.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped)	60.91 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped)	31.86 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped)	30.42 KB (0%)
@sentry/browser - Webpack (gzipped)	22.12 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)	73.34 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)	65 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped)	31.15 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped)	23.15 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed)	203.87 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)	93.76 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed)	68.69 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped)	34.11 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped)	67.7 KB (0%)
@sentry/react - Webpack (gzipped)	22.16 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped)	84.34 KB (0%)
@sentry/nextjs Client - Webpack (gzipped)	48.98 KB (0%)
@sentry-internal/feedback - Webpack (gzipped)	16.63 KB (0%)

[lforst]

lgtm! If, for some reason, this doesn't end up working or isn't robust enough we could investigate marking individual request objects as instrumented.