Skip to content

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 18, 2023

Also a small core refactor...

@mydea mydea requested a review from AbhiPrasad December 18, 2023 17:02
@mydea mydea self-assigned this Dec 18, 2023
public readonly name: string;

/** @deprecated This is never set. */
public getCurrentHub?: () => Hub;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just remove this tbh, nobody should be relying on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I'll remove it in a next step where I rewrite this to functional style!

@mydea mydea force-pushed the fn/browser-setuponce branch from 624c9d9 to 1a097a1 Compare December 19, 2023 08:12
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.14 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.57 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.16 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.23 KB (-0.12% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 29.85 KB (-0.09% 🔽)
@sentry/browser - Webpack (gzipped) 21.53 KB (-0.14% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 72.57 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 64.28 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 30.54 KB (-0.11% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 22.59 KB (-0.21% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 202.16 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 92.26 KB (-0.16% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 67.31 KB (-0.21% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 33.4 KB (-0.22% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.92 KB (-0.03% 🔽)
@sentry/react - Webpack (gzipped) 21.57 KB (-0.15% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.71 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 48.39 KB (-0.06% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 16.18 KB (0%)

@mydea mydea merged commit 91a6b4e into develop Dec 19, 2023
@mydea mydea deleted the fn/browser-setuponce branch December 19, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants