feat(replays): Add an SDK _experiments configuration flag to enable canvas recording #9723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Member
|
Let's make the options == what is described in https://github.com/getsentry/team-replay/issues/306 so that we can customize rrweb options without having to release a new SDK version |
billyvg
reviewed
Dec 5, 2023
Co-authored-by: Billy Vong <[email protected]>
billyvg
reviewed
Dec 5, 2023
packages/replay/src/types/replay.ts
Outdated
Comment on lines
237
to
238
| fps: number; | ||
| quality: number; |
Member
There was a problem hiding this comment.
Can we make these optional and set defaults for them?
billyvg
approved these changes
Dec 6, 2023
mydea
reviewed
Dec 7, 2023
packages/replay/src/replay.ts
Outdated
| ...(this.recordingMode === 'buffer' && { checkoutEveryNms: BUFFER_CHECKOUT_TIME }), | ||
| emit: getHandleRecordingEmit(this), | ||
| onMutation: this._onMutationHandler, | ||
| ...(this._options._experiments.canvas && { |
Member
There was a problem hiding this comment.
l: Could we extract this out to avoid having so many repetitions here, as they are quite long? Something like this:
const canvas = this._options._experiments.canvas;
// ...
onMutation: this._onMutationHandler,
...(canvas && {
recordCanvas: true,
sampling: {
canvas: canvas.fps || 4,
// ...
}
}
mydea
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDK _experiments configuration flag to enable canvas recording. It allows snapshot canvas recording at 4fps.
Closes https://github.com/getsentry/team-replay/issues/306