Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 28, 2023

17 more to go...

Luca Forstner and others added 12 commits November 27, 2023 16:03
This is code that isn't being used anywhere, and the code snippets are
out of date (look at custom transport code).

We can explore adding this back for v8.
…9665)

This PR adds support for uploading sourcemaps when using the
`@astrojs/vercel/*` adapters.

It seems that the adapter updates the config.outdir value too late for
our previous detection logic to
correctly detect the .vercel output directory. Furthermore, the adapter
for some reason first saves server
files to <root>/dist only to copy it later to <root>/.vercel/functions.
This copy command seems to happen too
late for when our sourcemaps plugin runs.

For these two reasons, we try to detect the used adapter (love that this
is much simpler in Astro than
Sveltekit) and adjust the assets glob to search for files in both,
`dist` and `.vercel`.
Astro 4.0.0 beta is out so let's adjust our peer deps!
I opted for an open max version for now. THere's a risk of this being
problematic with future major versions but I'd argue we'd get support
requests either way. The important part IMO is the lower bound.
This is a hotfix for
#9679.

We leaked Browser/React types into the generic `@sentry/types` package
which should not have any runtime specific types.
Adds the `assets` option to the Astro integration source maps
upload options.

It behaves just like the `assets` option of the Vite plugin, taking a
(array of) glob(s) and overriding the
default values. 
This came up in #9591 and I think it makes sense to give users with more
advanced/custom setups the ability to
override our defaults.
@Lms24 Lms24 requested review from HazAT and lforst November 28, 2023 10:13
@Lms24 Lms24 changed the base branch from develop to master November 28, 2023 10:14
@Lms24 Lms24 merged commit 85ff926 into master Nov 28, 2023
@Lms24 Lms24 deleted the prepare-release/7.83.0 branch November 28, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants