Skip to content

fix(tracing): Don't attach resource size if null #9669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix(tracing): Don't attach resource size if null #9669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b079d23
fix(tracing): Don't attach resource size if null
AbhiPrasad Nov 27, 2023
c50f70b
Merge branch 'develop' into abhi-resource-size-null-check
AbhiPrasad Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/tracing-internal/src/browser/metrics/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ function setResourceEntrySizeData(
dataKey: 'http.response_transfer_size' | 'http.response_content_length' | 'http.decoded_response_content_length',
): void {
const entryVal = entry[key];
if (entryVal !== undefined && entryVal < MAX_INT_AS_BYTES) {
if (entryVal != null && entryVal < MAX_INT_AS_BYTES) {
data[dataKey] = entryVal;
}
}
22 changes: 22 additions & 0 deletions packages/tracing-internal/test/browser/metrics/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,4 +189,26 @@ describe('_addResourceSpans', () => {
}),
);
});

// resource sizes can be set as null on some browsers
// https://github.com/getsentry/sentry/pull/60601
it('does not attach null resource sizes', () => {
const entry = {
initiatorType: 'css',
transferSize: null,
encodedBodySize: null,
decodedBodySize: null,
} as unknown as ResourceEntry;

_addResourceSpans(transaction, entry, '/assets/to/css', 100, 23, 345);

// eslint-disable-next-line @typescript-eslint/unbound-method
expect(transaction.startChild).toHaveBeenCalledTimes(1);
// eslint-disable-next-line @typescript-eslint/unbound-method
expect(transaction.startChild).toHaveBeenLastCalledWith(
expect.objectContaining({
data: {},
}),
);
});
});