Update type definitions for breadcrumbs #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
May 24, 2017
typescript/raven.d.ts
Outdated
| (raven: RavenStatic, ...args: any[]): RavenStatic; | ||
| } | ||
|
|
||
| interface BreadCrumb { |
There was a problem hiding this comment.
BreadCrumb for consistency should be written as Breadcrumb.
|
Anything that needs to happen before this can be approved? Btw. I'm willing to add more type definitions later on for more than just breadcrumbs. I'm sure there is demand for this. What's your opinion on this subject? |
As long as nothing breaks for users, I'm happy to approve more PRs. |
benvinegar
approved these changes
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the typings for some breadcrumb related methods to match documentation.
Related to #897