Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Nov 21, 2023

No description provided.

c298lee and others added 20 commits November 16, 2023 16:54
[Gitflow] Merge master into develop
feat(feedback): Option to make name and email required
…#9531)

This PR fix use case when original req url contain query params.
For example:

`api/v1/users/posts?param=1`

### Old behavior

sentry build req._reconstructedRoute as:
api/v1/users

### New behavior

sentry build req._reconstructedRoute as:
api/v1/users/posts
If communicating via debugger to generate a stack trace fails, then fall
back to a regular event, instead of throwing an uncaught exception.

If the parent process exits, exit the ANR child.
ref(feedback): Remove isAnonymous option from feedback
…hooks (#9588)

Add a `beforeSendFeedback` hook that replay listens to, to attach
replayId to the feedback event.
…r import (#9604)

We will be exporting the Feedback package from the `@sentry/browser`
package, so to avoid circular imports when we do, we should remove
imports from `@sentry/browser`

(this is what we did in Replay)
Although adding method is nice to span op, it duplicates information
that is already in span description.

In addition, we want to reduce the total list of span ops as much as
possible for cardinality reasons, `http.server` + span data about method
is good enough to understand intent here.
@lforst lforst requested review from Lms24 and mydea November 21, 2023 09:08
@lforst lforst changed the base branch from develop to master November 21, 2023 09:08
@lforst lforst force-pushed the prepare-release/7.81.1 branch from 0c8ac5f to aa459aa Compare November 21, 2023 09:09
@lforst lforst merged commit 88ceab4 into master Nov 21, 2023
@lforst lforst deleted the prepare-release/7.81.1 branch November 21, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.