Skip to content

test(browser-integration): Tweak promises a bit to reduce flakes in replay tests #9477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023
Merged

test(browser-integration): Tweak promises a bit to reduce flakes in replay tests #9477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/browser-integration-tests/suites/integrations/Breadcrumbs/dom/click/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ sentryTest('captures Breadcrumb for clicks & debounces them for a second', async
await page.waitForTimeout(1000);
await page.click('#button2');

await page.evaluate('Sentry.captureException("test exception")');

const eventData = await promise;
const [eventData] = await Promise.all([promise, page.evaluate('Sentry.captureException("test exception")')]);

expect(eventData.exception?.values).toHaveLength(1);

Expand Down
7 changes: 3 additions & 4 deletions ...ntegration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureRequestHeaders/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ sentryTest('captures request headers', async ({ getLocalTestPath, page, browserN
/* eslint-enable */
});

const request = await requestPromise;
const [request, replayReq1] = await Promise.all([requestPromise, replayRequestPromise1]);
const eventData = envelopeRequestParser(request);

expect(eventData.exception?.values).toHaveLength(1);
Expand All @@ -71,7 +71,6 @@ sentryTest('captures request headers', async ({ getLocalTestPath, page, browserN
},
});

const replayReq1 = await replayRequestPromise1;
const { performanceSpans: performanceSpans1 } = getCustomRecordingEvents(replayReq1);
expect(performanceSpans1.filter(span => span.op === 'resource.xhr')).toEqual([
{
Expand Down Expand Up @@ -142,7 +141,8 @@ sentryTest(
/* eslint-enable */
});

const request = await requestPromise;
const [request, replayReq1] = await Promise.all([requestPromise, replayRequestPromise1]);

const eventData = envelopeRequestParser(request);

expect(eventData.exception?.values).toHaveLength(1);
Expand All @@ -159,7 +159,6 @@ sentryTest(
},
});

const replayReq1 = await replayRequestPromise1;
const { performanceSpans: performanceSpans1 } = getCustomRecordingEvents(replayReq1);
expect(performanceSpans1.filter(span => span.op === 'resource.xhr')).toEqual([
{
Expand Down
28 changes: 15 additions & 13 deletions packages/browser-integration-tests/suites/replay/privacyInputMaskAll/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,22 +57,24 @@ sentryTest(
const url = await getLocalTestPath({ testDir: __dirname });

await page.goto(url);
const fullSnapshot = getFullRecordingSnapshots(await reqPromise0);

const text = 'test';

const [req0] = await Promise.all([reqPromise0, page.locator('#input').fill(text)]);
await forceFlushReplay();

const fullSnapshot = getFullRecordingSnapshots(req0);
const stringifiedSnapshot = JSON.stringify(fullSnapshot);
expect(stringifiedSnapshot.includes('Submit form')).toBe(false);
expect(stringifiedSnapshot.includes('Unmasked button')).toBe(true);

const text = 'test';

await page.locator('#input').fill(text);
const [req1] = await Promise.all([reqPromise1, page.locator('#input-unmasked').fill(text)]);
await forceFlushReplay();

const snapshots = getIncrementalRecordingSnapshots(await reqPromise1).filter(isInputMutation);
const snapshots = getIncrementalRecordingSnapshots(req1).filter(isInputMutation);
const lastSnapshot = snapshots[snapshots.length - 1];
expect(lastSnapshot.data.text).toBe('*'.repeat(text.length));

await page.locator('#input-unmasked').fill(text);
await forceFlushReplay();
const snapshots2 = getIncrementalRecordingSnapshots(await reqPromise2).filter(isInputMutation);
const lastSnapshot2 = snapshots2[snapshots2.length - 1];
expect(lastSnapshot2.data.text).toBe(text);
Expand Down Expand Up @@ -120,18 +122,18 @@ sentryTest(

await page.goto(url);

await reqPromise0;

const text = 'test';

await page.locator('#textarea').fill(text);
await Promise.all([reqPromise0, page.locator('#textarea').fill(text)]);
await forceFlushReplay();

const [req1] = await Promise.all([reqPromise1, page.locator('#textarea-unmasked').fill(text)]);
await forceFlushReplay();
const snapshots = getIncrementalRecordingSnapshots(await reqPromise1).filter(isInputMutation);

const snapshots = getIncrementalRecordingSnapshots(req1).filter(isInputMutation);
const lastSnapshot = snapshots[snapshots.length - 1];
expect(lastSnapshot.data.text).toBe('*'.repeat(text.length));

await page.locator('#textarea-unmasked').fill(text);
await forceFlushReplay();
const snapshots2 = getIncrementalRecordingSnapshots(await reqPromise2).filter(isInputMutation);
const lastSnapshot2 = snapshots2[snapshots2.length - 1];
expect(lastSnapshot2.data.text).toBe(text);
Expand Down