Skip to content

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Oct 27, 2023

No description provided.

github-actions bot and others added 15 commits October 25, 2023 11:52
[Gitflow] Merge master into develop
#9359)

We noticed we still sometimes see "too long sessions", and it seems this
is because of errors being tagged with a replay long after the session
expired. After some digging, this may be because we do not check session
expiration when adding the `replay_id` to the DSC. This PR fixes this.
See nodeca/pako#268, there is some issue with
pako tree shaking ootb.

We don't need all the inflation stuff in our bundle.
@lforst lforst requested a review from AbhiPrasad October 27, 2023 14:13
Luca Forstner and others added 2 commits October 27, 2023 16:25
This PR adds `Sentry.withMonitor`, a wrapping function similar to
`Sentry.startSpan` that wraps a callback with a cron monitor. Under the
hood it uses `Sentry.captureCheckIn`, but having this as a callback
means that users don't have to think about passing `checkInId` around.

```ts
import * as Sentry from '@sentry/node';

// with monitor will send checkin when callback is started/finished
// works with async and sync callbacks.
const result = Sentry.withMonitor(
  'dailyEmail',
  () => {
    // withCheckIn return value is same return value here
    return sendEmail();
  },
  {
    schedule: {
      type: 'crontab',
      value: '0 * * * *',
    },
    // 🇨🇦🫡
    timezone: 'Canada/Eastern',
  },
);
```
@lforst lforst force-pushed the prepare-release/7.76.0 branch from 70c0c54 to 64123ff Compare October 27, 2023 14:41
@lforst lforst force-pushed the prepare-release/7.76.0 branch from 64123ff to 8b76c18 Compare October 27, 2023 14:42
@AbhiPrasad AbhiPrasad mentioned this pull request Oct 27, 2023
3 tasks
@lforst lforst merged commit 13fe88a into master Oct 27, 2023
@lforst lforst deleted the prepare-release/7.76.0 branch October 27, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants