Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Oct 23, 2023

This was not covered well by our tests 😬 oops...

Fixes #9332

Copy link
Contributor

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we need this out quickly but we should add tests that catch this.

@mydea
Copy link
Member Author

mydea commented Oct 23, 2023

Well I changed the tests to catch this, just the way the test was written was not suited to catch this 😬

@lforst
Copy link
Contributor

lforst commented Oct 23, 2023

I should learn to read

@mydea mydea merged commit 1245e91 into develop Oct 23, 2023
@mydea mydea deleted the fn/fix-transaction branch October 23, 2023 13:07
HoukmellahMehdi pushed a commit to HoukmellahMehdi/sentry-javascript that referenced this pull request Oct 23, 2023
This was not covered well by our tests 😬 oops...

Fixes getsentry#9332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maximum call stack exceeded with sentry node (comes from sentry/integrations)

3 participants