Skip to content

test(loader): Add tests for loader window.sentryOnLoad #9331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

test(loader): Add tests for loader window.sentryOnLoad #9331

merged 1 commit into from
Nov 7, 2023

Conversation

@mydea
Copy link
Member

@mydea mydea commented Oct 23, 2023

@mydea mydea requested review from Lms24 and lforst October 23, 2023 09:32
@mydea mydea self-assigned this Oct 23, 2023
@mydea mydea mentioned this pull request Oct 23, 2023
Merged
@mydea mydea force-pushed the fn/loader-sentryOnLoad branch from 6ea6f33 to 855cb08 Compare November 7, 2023 08:33
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.9 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 56.15 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.97 KB (0%)
@sentry/browser - Webpack (gzipped) 21.29 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.44 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.09 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 196.88 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.28 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.8 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.27 KB (0%)
@sentry/react - Webpack (gzipped) 21.34 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.97 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 48.12 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 15.59 KB (added)

mydea added a commit to getsentry/sentry that referenced this pull request Nov 7, 2023
@mydea
feat(loader): Allow to configure 'window.sentryOnLoad' (#58574)
2c57b8a 
Allow to configure a new `window.sentryOnLoad` callback, which can be
defined before the Loader Script is loaded, thus allowing to streamline
timing issues & prevent issues if e.g. the loader script was not loaded.

tests added here
getsentry/sentry-javascript#9331

Closes #58428
@mydea mydea merged commit 47b6730 into develop Nov 7, 2023
@mydea mydea deleted the fn/loader-sentryOnLoad branch November 7, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

+1 more reviewer

@lforst lforst lforst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea @lforst @Lms24