Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Oct 20, 2023

Installing this on Node <18 produces install time errors, as the package is not compatible, e.g.:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>18.0.0' },
npm WARN EBADENGINE   current: { node: 'v16.18.0', npm: '8.19.2' }
npm WARN EBADENGINE }

We already try-catch the setupInstrumentation hook anyhow, so no need to check again here - if this fails we'll just skip running this integration.

Installing this on Node <18 produces install time errors, as the package is not compatible.
@mydea mydea requested review from AbhiPrasad and lforst October 20, 2023 06:54
@mydea mydea self-assigned this Oct 20, 2023
@mydea mydea merged commit 16594de into develop Oct 20, 2023
@mydea mydea deleted the fn/otel-node-fetch branch October 20, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants