Skip to content

fix(node): Check buffer length when attempting to parse ANR frame #9314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(node): Check buffer length when attempting to parse ANR frame #9314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/node/src/anr/websocket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,13 @@ class WebSocketInterface extends EventEmitter {
return;
}

// There needs to be atleast two values in the buffer for us to parse
// a frame from it.
// See: https://github.com/getsentry/sentry-javascript/issues/9307
if (buff.length <= 1) {
return;
}

const frame = parseFrame(buff);

if (isCompleteFrame(frame)) {
Expand Down