Skip to content

ref: Move isBrowser util fn from replay to util #9289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2023
Merged

ref: Move isBrowser util fn from replay to util #9289

merged 3 commits into from
Oct 19, 2023

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Oct 17, 2023

We need this in the new feedback integration.

@billyvg billyvg force-pushed the feat-move-is-browser-to-utils branch from a228306 to f5eedd8 Compare October 17, 2023 18:10
@billyvg billyvg marked this pull request as ready for review October 18, 2023 14:51
@billyvg billyvg enabled auto-merge (squash) October 18, 2023 15:02
@billyvg
ref: Move isBrowser util fn from replay to util
45e4156 
We need this in the new feedback integration.
@billyvg
fix mock
cb65595
@billyvg billyvg force-pushed the feat-move-is-browser-to-utils branch from 795a4cb to cb65595 Compare October 18, 2023 22:53
@billyvg billyvg disabled auto-merge October 18, 2023 22:54
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 82.5 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 71.65 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.63 KB (0%)
@sentry/browser - Webpack (gzipped) 21.24 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 73.01 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.68 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.07 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 233.76 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 87.08 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 62.71 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.44 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 82.96 KB (-0.02% 🔽)
@sentry/react - Webpack (gzipped) 21.27 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 99.37 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 47.54 KB (+0.01% 🔺)

@billyvg billyvg merged commit d7de20e into develop Oct 19, 2023
@billyvg billyvg deleted the feat-move-is-browser-to-utils branch October 19, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@billyvg @mydea