Skip to content

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Oct 6, 2023

This PR moves common ANR code to utils so it can be used for Electron renderer ANR detection.

watchdogTimer

Moved to utils with the addition of an enabled flag which isn't used in node

createDebugPauseMessageHandler

Handles messages from the debugger protocol.

  • Collects script ids for later filename lookups
  • Collects, converts and passes stack frames to a callback when the debugger pauses
  • Now uses stripSentryFramesAndReverse to remove Sentry frames!

@timfish timfish marked this pull request as ready for review October 6, 2023 15:01
@timfish timfish requested a review from AbhiPrasad October 8, 2023 13:42
@AbhiPrasad AbhiPrasad changed the title feat(electron): Move common ANR code to utils feat(utils): Move common node ANR code to utils Oct 11, 2023
@AbhiPrasad AbhiPrasad merged commit 729e432 into getsentry:develop Oct 11, 2023
@timfish timfish deleted the feat/electron-move-common-anr-code branch October 11, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants