Skip to content

Conversation

@onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Sep 11, 2023

Fixes: #8962

  • Moved component creation outside of the wrapper, passing location and routes as props.
  • Added a new test app for this use case.

@onurtemizkan onurtemizkan force-pushed the onur/react-use-routes-props branch 3 times, most recently from 0a6b3d8 to af30337 Compare September 11, 2023 14:40
@onurtemizkan onurtemizkan force-pushed the onur/react-use-routes-props branch from af30337 to 1497b7a Compare September 11, 2023 15:37
@onurtemizkan onurtemizkan marked this pull request as ready for review September 11, 2023 15:39
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.37 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.31 KB (+0.1% 🔺)
@sentry/browser - Webpack (gzipped) 21.91 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.07 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.43 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.51 KB (+0.18% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.4 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.93 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 60.77 KB (+0.18% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.31 KB (+0.11% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.39 KB (+0.05% 🔺)
@sentry/react - Webpack (gzipped) 21.94 KB (+0.11% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.26 KB (+0.05% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.87 KB (+0.06% 🔺)

@AbhiPrasad AbhiPrasad merged commit 47d0c89 into develop Sep 12, 2023
@AbhiPrasad AbhiPrasad deleted the onur/react-use-routes-props branch September 12, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RR6 wrapUseRoutes creates a new component on every render

3 participants