ref: Replace setup with preprocessEvent on Integration interface
#8969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
changed the title
setup with preprocessEvent on in Integration interfacesetup with preprocessEvent on Integration interface
mydea
force-pushed
the
fn/adjust-integration-hook
branch
2 times, most recently
from
9472141 to
e779e99
Compare
size-limit report 📦
|
Lms24
approved these changes
Sep 7, 2023
AbhiPrasad
approved these changes
Sep 8, 2023
mydea
force-pushed
the
fn/adjust-integration-hook
branch
from
e779e99 to
1b0a6d0
Compare
mydea
force-pushed
the
fn/adjust-integration-hook
branch
from
1b0a6d0 to
100ffef
Compare
mydea
added a commit
that referenced
this pull request
Sep 11, 2023
…8969) A change to #8956 based on feedback. I figured it makes sense to also pass the client (as in the one concrete example we have we actually need it 😅 ) - not sure if this should be the first or last argument, but IMHO you probably don't need this always and then it is nicer to have (event, hint) as the API...?
mydea
added a commit
that referenced
this pull request
Sep 11, 2023
…8969) A change to #8956 based on feedback. I figured it makes sense to also pass the client (as in the one concrete example we have we actually need it 😅 ) - not sure if this should be the first or last argument, but IMHO you probably don't need this always and then it is nicer to have (event, hint) as the API...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change to #8956 based on feedback.
I figured it makes sense to also pass the client (as in the one concrete example we have we actually need it 😅 ) - not sure if this should be the first or last argument, but IMHO you probably don't need this always and then it is nicer to have (event, hint) as the API...?