Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Sep 7, 2023

This is a fork of #8937, with only the "uncontroversial" stuff, mainly fixing that we only create HTTP breadcrumbs for outgoing requests.

In addition, this also migrates to using requestHook and responseHook instead of applyCustomAttributesOnSpan. We may have to revisit this later, but these hooks seem to have a better context awareness (=they are called in a more reasonable OTEL context, which gives the callbacks there better access to scope data etc). However that means we cannot (easily) pass both request and response as breadcrumb hints - not sure how important that is to us... For now I'd say that's OK.

Note that also requestHook is only called when the request finishes, so we already have all the response OTEL span attributes correctly set there.

@mydea mydea requested review from Lms24 and lforst September 7, 2023 08:13
@mydea mydea self-assigned this Sep 7, 2023
@mydea mydea requested a review from AbhiPrasad September 7, 2023 10:04
@mydea mydea merged commit 434507d into develop Sep 11, 2023
@mydea mydea deleted the fn/otel-http-breadcrumb-2 branch September 11, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants