ref(replay): Improve internal logging #8740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Aug 7, 2023
| `[Replay] Session duration (${Math.floor(duration / 1000)}s) is too ${ | ||
| tooShort ? 'short' : 'long' | ||
| }, not sending replay.`, | ||
| this._options._experiments.traceInternals, |
There was a problem hiding this comment.
Also noticed this, missed this in the refactor.
There was a problem hiding this comment.
I might have messed this up when rebasing #8716, sorry!
There was a problem hiding this comment.
no big deal either way, it's just internal logging ;)
Lms24
approved these changes
Aug 7, 2023
| `[Replay] Session duration (${Math.floor(duration / 1000)}s) is too ${ | ||
| tooShort ? 'short' : 'long' | ||
| }, not sending replay.`, | ||
| this._options._experiments.traceInternals, |
There was a problem hiding this comment.
I might have messed this up when rebasing #8716, sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This delays adding the internal replay logging breadcrumbs to the next tick, to avoid race conditions on initial logs where replay may not be initialized yet.
With this, you should get proper log breadcrumbs in a replay for itself: