Skip to content

Conversation

@priscilawebdev
Copy link
Member

without && pnpm start the test will always pass as the error really only appears when lauching the application.

Related to #8286

@priscilawebdev priscilawebdev requested review from lforst and mydea July 23, 2023 20:03
@lforst lforst changed the title ref(remix-2e2): Update recipe test build command ref(e2e): Update Remix recipe build command Jul 24, 2023
@mydea
Copy link
Member

mydea commented Jul 24, 2023

We had to revert this, because this starts the server and then hangs because it doesn't complete.

I think what we have to do is setup playwright (similar to e.g. the nextjs tests), where we start the next server, test that we can access e.g. localhost:xxxx/, and then close the server.

@priscilawebdev
Copy link
Member Author

priscilawebdev commented Jul 24, 2023

@mydea did you have to revert this? but it was not merged, was it? I will setup playwright. Thank you 🙏

@mydea
Copy link
Member

mydea commented Jul 24, 2023

@mydea did you have to revert this? but it was not merged, was it? I will setup playwright. Thank you 🙏

Revert in the sense of remove the pnpm start part because it lead to the tests hanging 😅 If you need any help/guidance let me (or somebody else from SDK team) know, we're happy to help :)

@mydea
Copy link
Member

mydea commented Jul 25, 2023

Replaced by #8633

@mydea mydea closed this Jul 25, 2023
@mydea mydea deleted the priscila/ref/update-e2e-remix-test-recipe branch December 3, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants