Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Jul 19, 2023

Due to the way pnpm handles versions, the version * we use in E2E tests is actually incorrect, because it installs the lowest version it can find, e.g. 0.1.0. This is usually not a problem as when we use verdaccio, there is only a single version in the repository. however, when running things locally/debugging stuff, and you run pnpm install without verdaccio, stuff fails. This updates the versions used in E2E tests to latest || *, which results in a correct resolution.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mydea mydea force-pushed the fn/e2e-versions branch from 3f659b7 to b820618 Compare July 20, 2023 15:24
@mydea mydea merged commit 67c3b6a into develop Jul 21, 2023
@mydea mydea deleted the fn/e2e-versions branch July 21, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants