Skip to content

fix(replay): Handle errors in beforeAddRecordingEvent callback #8548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix(replay): Handle errors in beforeAddRecordingEvent callback #8548

merged 1 commit into from
Jul 17, 2023

Conversation

@mydea
Copy link
Member

@mydea mydea commented Jul 17, 2023

When an error occurs in beforeAddRecordingEvent, we just skip this event and log the error.

Closes #8542

@mydea mydea requested a review from billyvg July 17, 2023 08:43
@mydea mydea self-assigned this Jul 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.95 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 69.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 60.38 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.9 KB (0%)
@sentry/browser - Webpack (minified) 71.51 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.58 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 30.11 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 28.16 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.43 KB (+0.02% 🔺)
@sentry/replay - Webpack (gzipped + minified) 43.15 KB (+0.13% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.51 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.83 KB (+0.02% 🔺)

@mydea mydea force-pushed the fn/handle-beforeAddRecordingEvent-error branch from e06952a to df40646 Compare July 17, 2023 09:38
@mydea mydea force-pushed the fn/handle-beforeAddRecordingEvent-error branch from df40646 to 90bda07 Compare July 17, 2023 11:42
@mydea mydea merged commit c2b1bfd into develop Jul 17, 2023
@mydea mydea deleted the fn/handle-beforeAddRecordingEvent-error branch July 17, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@billyvg billyvg Awaiting requested review from billyvg

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If a user callback beforeAddRecordingEvent throws, don't report SDK internal error

3 participants

@mydea @Lms24