Skip to content

test(e2e): Fix remix E2E test & types #8495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2023
Merged

test(e2e): Fix remix E2E test & types #8495

merged 1 commit into from
Jul 11, 2023

Conversation

@mydea
Copy link
Member

@mydea mydea commented Jul 11, 2023 •
edited
Loading

Improves the types for the E2E tests, as well as checking that they are all good.
Fixes the remix E2E test which never timed out - for whatever reason this was ever working...?

@mydea mydea self-assigned this Jul 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.95 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 69.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 60.38 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.9 KB (0%)
@sentry/browser - Webpack (minified) 71.51 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.57 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 30.11 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 28.14 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.42 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 43.1 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.5 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.82 KB (0%)

@mydea mydea force-pushed the fn/fix-e2e-tests branch from 0dbb4bb to 83a8e42 Compare July 11, 2023 11:52
@mydea mydea force-pushed the fn/fix-e2e-tests branch from de0b926 to 4e20482 Compare July 11, 2023 14:00
@mydea mydea changed the title test(e2e): Fix types test(e2e): Fix remix E2E test & types Jul 11, 2023
@mydea mydea marked this pull request as ready for review July 11, 2023 14:16
@mydea mydea requested review from AbhiPrasad and Lms24 July 11, 2023 14:16
@mydea mydea merged commit 81baae6 into develop Jul 11, 2023
@mydea mydea deleted the fn/fix-e2e-tests branch July 11, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mydea @Lms24 @AbhiPrasad