build(angular): Avoid loading all @types/ packages
#8466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `@sentry/angular` uses TS 4.0, but the default behavior of TS is to load _all_ `@types/xxx` packages it can find in node_modules, the build will fail if _any_ other package uses a types package that uses newer TS features. In order to avoid this, we opt out of the automatic types resolution - since we are not using any `@types/xxx` package in angular as of now, this doesn't change anything.
Contributor
size-limit report 📦
|
lforst
approved these changes
Jul 6, 2023
Lms24
approved these changes
Jul 6, 2023
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
This only happens in angular, right; not in angular-ivy?
Member
Author
angular-ivy is on the "global" TS version, so it is not affected! |
AbhiPrasad
pushed a commit
that referenced
this pull request
Jul 6, 2023
As `@sentry/angular` uses TS 4.0, but the default behavior of TS is to load _all_ `@types/xxx` packages it can find in node_modules, the build will fail if _any_ other package uses a types package that uses newer TS features. In order to avoid this, we opt out of the automatic types resolution - since we are not using any `@types/xxx` package in angular as of now, this doesn't change anything. See https://www.typescriptlang.org/tsconfig/types.html for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
@sentry/angularuses TS 4.0, but the default behavior of TS is to load all@types/xxxpackages it can find in node_modules, the build will fail if any other package uses a types package that uses newer TS features.In order to avoid this, we opt out of the automatic types resolution - since we are not using any
@types/xxxpackage in angular as of now, this doesn't change anything.See https://www.typescriptlang.org/tsconfig/types.html for details.