feat(node): Add tracing without performance to Node Undici #8449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
ale-cota and
stephanie-anderson
and removed request for
a team
|
I have no idea why these are failing - the tests all pass for me locally :/ |
AbhiPrasad
force-pushed
the
abhi-twp-node-undici
branch
from
d1856cc to
642001a
Compare
size-limit report 📦
|
AbhiPrasad
force-pushed
the
abhi-twp-node-undici
branch
2 times, most recently
from
9e6c6ef to
fb3ff50
Compare
|
The bug with Undici tests ended up being an issue with multiple test server using the same port I'm going to merge this in for now, but I have a todo to come in and clean up the tests here. |
AbhiPrasad
force-pushed
the
abhi-twp-node-undici
branch
from
c95d42b to
3427795
Compare
AbhiPrasad
force-pushed
the
abhi-twp-node-undici
branch
from
6166a32 to
3fea09d
Compare
Lms24
approved these changes
Jul 11, 2023
| [ | ||
| 'simple url', | ||
| 'http://localhost:18099', | ||
| 'http://localhost:18100', |
There was a problem hiding this comment.
no action required: Any particular reason for the port change?
There was a problem hiding this comment.
Yes - this was because 18099 was used by another test so running the tests in parallel would lead to issues. See: #8449 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #8352
Updates the Node Undici integration to always attach
sentry-traceheaders to outgoing requests.This can be controlled with the top level
tracePropagationOptionsoption.