chore: Make sure we run sentry-internal unit tests #8431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
mydea
approved these changes
Jun 30, 2023
Member
|
One more reason to finally tackle #6711 😅 this is basically exactly this, we want to not run really private tests but run tests for internal packages. But for now this is a good fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of #8430, this PR makes a quick fix to make sure we are running unit tests for
@sentry-internal/eslint-plugin,@sentry-internal/tracing, and@sentry-internal/replay-worker. This was found not to be running before because we had a blanket--ignore @sentry-internal/*when making lerna run tests.