Skip to content

fix(nextjs): Guard for non-absolute paths when injecting sentry config #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2023
Merged

fix(nextjs): Guard for non-absolute paths when injecting sentry config #8151

merged 2 commits into from
May 22, 2023

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented May 17, 2023

Builds on #8142

@lforst lforst requested review from AbhiPrasad and Lms24 May 17, 2023 13:35
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.03 KB (+0.05% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.68 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.59 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.15 KB (+0.12% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.2 KB (+0.16% 🔺)
@sentry/browser - Webpack (minified) 69.07 KB (+0.05% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.22 KB (+0.16% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.16 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.67 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.9 KB (+0.1% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 48.24 KB (+1.32% 🔺)
@sentry/replay - Webpack (gzipped + minified) 42.1 KB (+1.53% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 67.21 KB (+1.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.11 KB (+1.23% 🔺)

@lforst lforst merged commit 3dd4a58 into develop May 22, 2023
@lforst lforst deleted the lforst-fix branch May 22, 2023 08:36
@AbhiPrasad AbhiPrasad mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lforst @Lms24