test: Refactor playwright bundle generation #8029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using linked files for the CDN tests, we place symlinks in the `dist` folder and reference those. This makes it easier to test stuff that relies on URLs as well.
AbhiPrasad
approved these changes
May 3, 2023
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #8024, I noticed that bundle tests were failing, because we couldn't really run the playwright tests in bundle mode when serving the app on a URL instead via
file://. This is because of the way we reference bundle files, which have been referenced as e.g.<script src="/Users/francesco/git/sentry-javascript/packages/browser/build/bundle.min.js">. This doesn't play well with serving from a URL likehttps://sentry-test.io/cdn.bundle.js.In order to make this work and streamline this, I refactored this to instead keep a
tmp/staticfolder for all of the integration tests, where we can cache static files that are the same for all test runs (e.g. cdn.bundle.js, the integrations or loader.js). Where possible, we make those symlinks. Then we put a symlink to these files into thedistfolder of each test, and can reference them from there. This works in both file & URL serving mode.