Skip to content

feat(tracing): Replace sentence style browser span keys with snake case #7978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2023
Merged

feat(tracing): Replace sentence style browser span keys with snake case #7978

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80ee8f8
feat(perf-issues): Replace sentence style keys with snake case
narsaynorath Apr 26, 2023
9a43383
Merge branch 'develop' into nar/feat/replace-sentence-style-browser-s…
narsaynorath Apr 27, 2023
286c00a
http.transfer_size -> http.response_transfer_size
narsaynorath Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/replay/test/fixtures/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ export function Transaction(traceId?: string, obj?: Partial<Event>): any {
},
{
data: {
'Transfer Size': 1097,
'Encoded Body Size': 797,
'Decoded Body Size': 1885,
'http.transfer_size': 1097,
'http.response_content_length': 797,
'http.decoded_response_content_length': 1885,
'resource.render_blocking_status': 'non-blocking',
},
description: '/favicon.ico',
Expand Down
6 changes: 3 additions & 3 deletions packages/tracing-internal/src/browser/metrics/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,13 +402,13 @@ export function _addResourceSpans(
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const data: Record<string, any> = {};
if ('transferSize' in entry) {
data['Transfer Size'] = entry.transferSize;
data['http.transfer_size'] = entry.transferSize;
}
if ('encodedBodySize' in entry) {
data['Encoded Body Size'] = entry.encodedBodySize;
data['http.response_content_length'] = entry.encodedBodySize;
}
if ('decodedBodySize' in entry) {
data['Decoded Body Size'] = entry.decodedBodySize;
data['http.decoded_response_content_length'] = entry.decodedBodySize;
}
if ('renderBlockingStatus' in entry) {
data['resource.render_blocking_status'] = entry.renderBlockingStatus;
Expand Down
12 changes: 6 additions & 6 deletions packages/tracing-internal/test/browser/metrics/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ describe('_addResourceSpans', () => {
// eslint-disable-next-line @typescript-eslint/unbound-method
expect(transaction.startChild).toHaveBeenLastCalledWith({
data: {
['Decoded Body Size']: entry.decodedBodySize,
['Encoded Body Size']: entry.encodedBodySize,
['Transfer Size']: entry.transferSize,
['http.decoded_response_content_length']: entry.decodedBodySize,
['http.response_content_length']: entry.encodedBodySize,
['http.transfer_size']: entry.transferSize,
['resource.render_blocking_status']: entry.renderBlockingStatus,
},
description: '/assets/to/css',
Expand Down Expand Up @@ -158,9 +158,9 @@ describe('_addResourceSpans', () => {
expect(transaction.startChild).toHaveBeenLastCalledWith(
expect.objectContaining({
data: {
['Decoded Body Size']: entry.decodedBodySize,
['Encoded Body Size']: entry.encodedBodySize,
['Transfer Size']: entry.transferSize,
['http.decoded_response_content_length']: entry.decodedBodySize,
['http.response_content_length']: entry.encodedBodySize,
['http.transfer_size']: entry.transferSize,
['resource.render_blocking_status']: entry.renderBlockingStatus,
},
}),
Expand Down