feat(node): Make Undici a default integration. #7967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
Lms24 and
mydea
and removed request for
a team
Lms24
reviewed
Apr 26, 2023
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
This won't cause issues for older Node versions, right?
Member
Author
It should not, we can confirm this since we run the unit tests on older Node versions. We have version checks and try-catch guards also: sentry-javascript/packages/node/src/integrations/undici/index.ts Lines 71 to 72 in d1b09c6 |
Lms24
approved these changes
Apr 26, 2023
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Ahh I forgot about the version check. And good point about the tests. Let's go then!
AbhiPrasad
force-pushed
the
abhi-node-undici-default
branch
from
0a93f16 to
fadd795
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been default in Next.js and Sveltekit for a while now, let's make it a default for Node especially since Node 20 is released.