Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Apr 25, 2023

Noticed that one comment was copy-pasted but not changed 😅 So removed it and slightly refactored it to avoid re-assigning the variable. Also renamed the variable as I found it a bit confusing (it is not always overridden!), while at it.

@mydea mydea requested review from AbhiPrasad, Lms24 and lforst April 25, 2023 12:25
@mydea mydea self-assigned this Apr 25, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.02 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 65.66 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.56 KB (-0.04% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 58.12 KB (-0.01% 🔽)
@sentry/browser - Webpack (gzipped + minified) 21.17 KB (-0.02% 🔽)
@sentry/browser - Webpack (minified) 69.07 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped + minified) 21.19 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.03 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.59 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.82 KB (-0.02% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 46.26 KB (+0.1% 🔺)
@sentry/replay - Webpack (gzipped + minified) 40.14 KB (+0.12% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 65.12 KB (+0.07% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 58.1 KB (+0.08% 🔺)

@mydea mydea merged commit 82cebd3 into develop Apr 26, 2023
@mydea mydea deleted the fn/normalize branch April 26, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants