Skip to content

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 20, 2023

This also incorporates feedback from @Lms24 to properly handle the case when we both fail to parse JSON AND still truncate the body.

@mydea mydea added Type: Bug Package: replay Issues related to the Sentry Replay SDK labels Apr 20, 2023
@mydea mydea requested review from AbhiPrasad and Lms24 April 20, 2023 15:11
@mydea mydea self-assigned this Apr 20, 2023
@mydea
Copy link
Member Author

mydea commented Apr 20, 2023

cc @ryan953 so you are aware which combinations of warnings are possible:

  • nothing
  • JSON_TRUNCATED
  • TEXT_TRUNCATED
  • INVALID_JSON
  • INVALID_JSON & TEXT_TRUNCATED

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.03 KB (+0.05% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.66 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.56 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.12 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.17 KB (+0.03% 🔺)
@sentry/browser - Webpack (minified) 69.07 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.19 KB (+0.03% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.03 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.59 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.82 KB (+0.03% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 46.05 KB (+0.02% 🔺)
@sentry/replay - Webpack (gzipped + minified) 39.93 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 64.92 KB (+0.02% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 57.9 KB (+0.03% 🔺)

@mydea mydea force-pushed the fn/better-invalid-json-fallback branch from 2f77f5d to 2fadd5a Compare April 20, 2023 15:27
@mydea mydea merged commit 390faf3 into develop Apr 21, 2023
@mydea mydea deleted the fn/better-invalid-json-fallback branch April 21, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Package: replay Issues related to the Sentry Replay SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants