Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Apr 19, 2023

Because we're now using Next.js source map resolving server for dev mode we don't need to run the webpack plugin at all in dev mode to get resolved stack traces.

If the plugin isn't silenced in the options it is extremely noisy in dev mode without doing anything. This PR fixes that.

@lforst lforst requested review from AbhiPrasad and Lms24 April 19, 2023 10:38
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.97 KB (-0.35% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 65.48 KB (-0.28% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.51 KB (-0.4% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 57.94 KB (-0.31% 🔽)
@sentry/browser - Webpack (gzipped + minified) 21.11 KB (-0.35% 🔽)
@sentry/browser - Webpack (minified) 68.89 KB (-0.26% 🔽)
@sentry/react - Webpack (gzipped + minified) 21.14 KB (-0.35% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.98 KB (-0.15% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.54 KB (-0.27% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.77 KB (-0.3% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 45.35 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 39.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 64.22 KB (-0.12% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 57.19 KB (-0.13% 🔽)

@lforst lforst enabled auto-merge (squash) April 19, 2023 11:45
@lforst lforst merged commit ef33250 into develop Apr 19, 2023
@lforst lforst deleted the lforst-dont-include-plugin-in-dev-mode branch April 19, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants