fix(sveltekit): Avoid capturing "Not Found" errors in server handleError wrapper
#7898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
AbhiPrasad and
mydea
and removed request for
a team
Lms24
changed the title
handleError wrapperhandleError wrapper
AbhiPrasad
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incoming page load requests on the server side for unknown/invalid routes will throw a
Error: Not found: /unknown/routeerror in the serverhandleErrorhook. In our wrapper, we don't want to catch these errors (similarly to 404 errors in thewrapLoadWithSentrywrapper).