build(sveltekit): Upgrade to Rollup 3 #7862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps rollup from 2.6 to 3.2 - for now just in the SvelteKit SDK. We need this to dynamically import users'
svelte.config.jsfiles at build time. More specifically, rollup 3 introducesoutput.dynamicImportsInCjswhich stops rollup from converting dynamicimportstatements to dynamic (async)requirecalls.ESM and CJS... Just gotta love it.
We can think about updating rollup in the other packages as well but the change is ofc riskier and will probably require a lot more changes.
sort of ref #7669