fix(sveltekit): Improve server-side grouping by removing stack frame module #7835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
AbhiPrasad and
mydea
and removed request for
a team
AbhiPrasad
approved these changes
Apr 13, 2023
Lms24
force-pushed
the
lms/sveltekit-strip-stack-frame-module-prop
branch
from
e846c08 to
7fb5606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a custom
RewriteFramesiteratee to the server SDK whichRewriteFrames()without custom optionsmodulefield from each stack frameRemoving the
modulefield improves grouping because for some reason, our stack trace processing pipeline isn't able to resolve the bundled module name to the original file name correctly, leading to a new issue group for the same error, every time the app is built. I suspect this is because of the unique Ids that Vite assigns to modules or due to something that sorcery does when flattening source maps. By removingmodulefield the grouping algorithm falls back to thefilenamefield, which is correctly resolved and hence grouping works as expected.ref #7669