Skip to content

ref(replay): Always send replay_start_timestamp #7773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2023
Merged

ref(replay): Always send replay_start_timestamp #7773

merged 1 commit into from
Apr 7, 2023

Conversation

@mydea
Copy link
Member

@mydea mydea commented Apr 6, 2023

This should be sent with each segment now.

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Apr 6, 2023
@mydea mydea requested review from JoshFerge and billyvg April 6, 2023 08:22
@mydea mydea self-assigned this Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.91 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.38 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.47 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 57.83 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.09 KB (0%)
@sentry/browser - Webpack (minified) 68.82 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.11 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.89 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.48 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.71 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.88 KB (-0.07% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.85 KB (-0.06% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.76 KB (-0.07% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.79 KB (-0.07% 🔽)

@mydea
ref(replay): Always send replay_start_timestamp
bb85559 
This should be sent with each segment now.
@mydea mydea force-pushed the fn/replay-initial-timestamp branch from 9d42f44 to bb85559 Compare April 6, 2023 08:58
@mydea mydea merged commit ad8ce23 into develop Apr 7, 2023
@mydea mydea deleted the fn/replay-initial-timestamp branch April 7, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billyvg billyvg billyvg approved these changes

@JoshFerge JoshFerge JoshFerge approved these changes

Assignees

@mydea mydea

Labels

Package: replay Issues related to the Sentry Replay SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mydea @billyvg @JoshFerge