fix(integrations): Ensure HttpClient integration works with Axios #7714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Lms24
reviewed
Apr 3, 2023
lforst
approved these changes
Apr 3, 2023
This streamlines the integration to use the general fetch/xhr instrumentation, instead of adding it's own. This also adds `request_headers` to the xhr info (which we'll also need for replay). It also ensures that we always correctly get the method/url from fetch options, even when they are other valid objects.
mydea
force-pushed
the
fn/httpclient-axios
branch
from
84f5ec4 to
b1825e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
HttpClientintegration to use the "regular" instrumentation handling, ensuring this works with Axios.This also adds
request_headersto the xhr info (which we'll also need for replay).It also ensures that we always correctly get the method/url from fetch options, even when they are other valid objects.
Closes #7615