feat(node): Sanitize URLs in Span descriptions and breadcrumbs #7667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michi Hoffmann <[email protected]>
Co-authored-by: Michi Hoffmann <[email protected]>
2 tasks
Lms24
requested review from
a team,
lforst and
mydea
and removed request for
a team
Lms24
changed the title
size-limit report 📦
|
AbhiPrasad
approved these changes
Mar 30, 2023
|
Merging so we can include with next release |
This was referenced Mar 30, 2023
Lms24
added a commit
that referenced
this pull request
Apr 5, 2023
In #7667 we missed that our `urlToOptions` helper function is actually called to normalize request options that are then passed to the actual http client. Meaning, we shouldn't have redacted the authority in this function but at a later time when we extract the sanitized version (`extractUrl`). This PR changes the redaction location accordingly and hence fixes requests with authority not being sent properly. Co-authored-by: Luca Forstner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up on #7206. just opening a new one because I can't push to the fork.
It has already been thoroughly reviewed and I just added a few clarifying comments and removed the deprecation as discussed in #7206 (comment).
All credits go to @aldenquimby
refs getsentry/team-webplatform-meta#2