Skip to content

feat(ember): Remove @sentry/tracing dependency from Ember SDK #7583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2023
Merged

feat(ember): Remove @sentry/tracing dependency from Ember SDK #7583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f95669
Remove `@sentry/tracing` dependency from Ember SDK
timfish Mar 23, 2023
8f561ac
Merge branch 'develop' into feat/tracing/ember
timfish Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/ember/addon/instance-initializers/sentry-performance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,15 +386,15 @@ export async function instrumentForPerformance(appInstance: ApplicationInstance)
// Maintaining backwards compatibility with config.browserTracingOptions, but passing it with Sentry options is preferred.
const browserTracingOptions = config.browserTracingOptions || config.sentry.browserTracingOptions || {};

const tracing = await import('@sentry/tracing');
const { BrowserTracing } = await import('@sentry/browser');

const idleTimeout = config.transitionTimeout || 5000;

const existingIntegrations = (sentryConfig['integrations'] || []) as Integration[];

sentryConfig['integrations'] = [
...existingIntegrations,
new tracing.Integrations.BrowserTracing({
new BrowserTracing({
routingInstrumentation: (customStartTransaction, startTransactionOnPageLoad) => {
const routerMain = appInstance.lookup('router:main');
let routerService = appInstance.lookup('service:router') as
Expand All @@ -421,7 +421,7 @@ export async function instrumentForPerformance(appInstance: ApplicationInstance)
];

class FakeBrowserTracingClass {
static id = tracing.BROWSER_TRACING_INTEGRATION_ID;
static id = 'BrowserTracing';
public name = FakeBrowserTracingClass.id;
setupOnce() {
// noop - We're just faking this class for a lookup
Expand Down
1 change: 0 additions & 1 deletion packages/ember/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"dependencies": {
"@embroider/macros": "^1.9.0",
"@sentry/browser": "7.44.2",
"@sentry/tracing": "7.44.2",
"@sentry/types": "7.44.2",
"@sentry/utils": "7.44.2",
"ember-auto-import": "^1.12.1 || ^2.4.3",
Expand Down