Skip to content

ref(sveltekit): Rewrite sentryHandle using trace func #7559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2023
Merged

ref(sveltekit): Rewrite sentryHandle using trace func #7559

merged 2 commits into from
Mar 22, 2023

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 21, 2023

Rewrite the handle function wrapper using the trace function introduced in #7556

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.44 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 63.52 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.57 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (0%)
@sentry/browser - Webpack (minified) 71.65 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.85 KB (-0.21% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.77 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.08 KB (+0.07% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.21 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.4 KB (+0.03% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.95 KB (0%)

Base automatically changed from abhi-trace-func to develop March 22, 2023 10:40
@AbhiPrasad AbhiPrasad force-pushed the abhi-sentry-handle-trace-func branch from a9908ef to 3bfb9f7 Compare March 22, 2023 11:00
@AbhiPrasad AbhiPrasad requested a review from Lms24 March 22, 2023 11:01
@AbhiPrasad AbhiPrasad marked this pull request as ready for review March 22, 2023 11:01
Lms24
Lms24 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 22, 2023 14:03
@AbhiPrasad AbhiPrasad merged commit d265fe5 into develop Mar 22, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-sentry-handle-trace-func branch March 22, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AbhiPrasad @Lms24