Skip to content

fix(vue): Do not depend on window.location for SSR environments #7518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2023
Merged

fix(vue): Do not depend on window.location for SSR environments #7518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vue/src/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ export function vueRouterInstrumentation(

// We have to start the pageload transaction as early as possible (before the router's `beforeEach` hook
// is called) to not miss child spans of the pageload.
if (startTransactionOnPageLoad) {
// We check that window & window.location exists in order to not run this code in SSR environments.
if (startTransactionOnPageLoad && WINDOW && WINDOW.location) {
startTransaction({
name: WINDOW.location.pathname,
op: 'pageload',
Expand Down