Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Mar 17, 2023

This adds a new script & workflow that can be run to detect flaky tests.

It runs tests a given amount of times (10 to try it out), and logs errors if they happen, else log the average run time (note this is a bit ~~ as it just takes the duration to run the given test, separated by run count - so parallelization will skew this a bit. Still it should give a decent insight how long a given test takes).

Update:

This now runs automatically on PRs that change any browser integration tests. It will run all changed integration tests 100x, separate from the rest of the integration tests.
note that this is not merge blocking, but will report if it fails.

You can also choose to run this manually via workflow_dispatch, in which case it will run all tests 5x (for now).

@mydea mydea requested review from AbhiPrasad and Lms24 March 17, 2023 10:36
@mydea mydea self-assigned this Mar 17, 2023
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.49 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 63.56 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.11 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 56.63 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.68 KB (0%)
@sentry/browser - Webpack (minified) 72.17 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.72 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.05 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 33.78 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.14 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.07 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.22 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.3 KB (+0.01% 🔺)

@mydea mydea force-pushed the fn/flaky-test-detector branch from 4c3902a to 84e59c3 Compare March 17, 2023 12:53
@mydea mydea force-pushed the fn/flaky-test-detector branch from 9d362f4 to 881fbb8 Compare March 20, 2023 08:21
@mydea mydea merged commit e1a9c66 into develop Mar 20, 2023
@mydea mydea deleted the fn/flaky-test-detector branch March 20, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants